Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEP-20] Configure high-availability settings for gardener-resource-manager #6685

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Sep 16, 2022

How to categorize this PR?

/area high-availability
/area control-plane
/kind enhancement

What this PR does / why we need it:
This PR adds Pod Topology Spread Constraints to the gardener-resource-manager of shoot control-planes and replaces the formerly used podAntiAffinity.

Which issue(s) this PR fixes:
Fixes parts of #6529

Special notes for your reviewer:
Since the Pod Topology Webook is not applied to GRM itself, we need to workaround the rolling update issue kubernetes/kubernetes#98215 directly in the deployment procedure.

Release note:

The `gardener-resource-manager` deployment was changed from pod anti-affinity to [Topology Spread Constraints](https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/). Non-HA shoot clusters will still have the `gardener-resource-manager` pods being scheduled on different nodes on a best-effort basis. For HA clusters, the Topology Spread Constraints make sure that a distribution across nodes (single-zone) and zones (multi-zonal) is guaranteed, in order to tolerate failures in these domains.

@gardener-prow gardener-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 16, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added area/high-availability High availability related area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Sep 16, 2022
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 16, 2022
@timuthy timuthy marked this pull request as ready for review September 19, 2022 06:22
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 19, 2022

@timuthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-check-vulnerabilities 570378a link false /test pull-gardener-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@timuthy
Copy link
Contributor Author

timuthy commented Sep 19, 2022

/test pull-gardener-integration

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sounds reasonable!
/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@shafeeqes
Copy link
Contributor

/milestone v1.56

@gardener-prow gardener-prow bot added this to the v1.56 milestone Sep 20, 2022
@gardener-prow gardener-prow bot merged commit 1c7a68f into gardener:master Sep 20, 2022
@timuthy timuthy deleted the enhancement.gep20-grm branch September 20, 2022 06:07
@rfranzke rfranzke changed the title [GEP-20] Add Topology Spread Constraints for gardener-resource-manager [GEP-20] Configure high-availability settings for gardener-resource-manager Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related area/high-availability High availability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants