Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline gardener-scheduler entrypoint and controllers #6690

Merged
merged 7 commits into from
Sep 23, 2022
Merged

Streamline gardener-scheduler entrypoint and controllers #6690

merged 7 commits into from
Sep 23, 2022

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
This PR streamlines the main entrypoint of the gardener-scheduler and its controllers so that they are in line with all other components which have been refactored to native controller-runtime functionality.

Which issue(s) this PR fixes:
Part of #4251

Release note:

The `metrics` port of the `gardener-scheduler` is no longer hard-coded to `9090` but now uses the same value as the container target port (configurable via the component configuration).

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Sep 19, 2022
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 19, 2022
@rfranzke rfranzke force-pushed the streamline/scheduler branch 2 times, most recently from 70c3d10 to 970ab4f Compare September 19, 2022 07:59
@rfranzke
Copy link
Member Author

/cc @ary1992

@ary1992
Copy link
Contributor

ary1992 commented Sep 20, 2022

/assign

@rfranzke rfranzke mentioned this pull request Sep 20, 2022
Merged
@rfranzke
Copy link
Member Author

Failure due to VPN looks unrelated to the changes:

/test pull-gardener-e2e-kind

ialidzhikov
ialidzhikov reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2022
@ary1992
Copy link
Contributor

ary1992 commented Sep 22, 2022

/lgtm

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 22, 2022
@rfranzke
Drop dead/unused code
53a0ce0
@rfranzke
Streamline metrics service port and add readiness probe
9e9a781
@rfranzke
Drop scheduler/controller/common package
0b25775 
There was no usage other than from the `shoot` controller package
@rfranzke
Make shoot.Reconciler public
27f967e 
like we do it for all other refactored controller-runtime controllers
@rfranzke
Rework AddToManager functionality
3ba9ab9 
Similar to other refactored controller-runtime controllers now
@rfranzke
Rework main entrypoint
257dc48 
Minor cosmetics and adaptations so that it is in line with GCM, gardenlet entrypoint
@rfranzke
Address PR review feedback
05fdf53
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 23, 2022

New changes are detected. LGTM label has been removed.

@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 23, 2022 •
edited
Loading

@rfranzke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-check-vulnerabilities 05fdf53 link false /test pull-gardener-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rfranzke
Copy link
Member Author

Rebased after conflicts, adding labels for merge.

@rfranzke rfranzke added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@gardener-prow gardener-prow bot merged commit 7a9282d into gardener:master Sep 23, 2022
@rfranzke rfranzke deleted the streamline/scheduler branch September 23, 2022 14:10
@rfranzke rfranzke mentioned this pull request Oct 19, 2022
Closed
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov left review comments

@ary1992 ary1992 Awaiting requested review from ary1992

@timebertt timebertt Awaiting requested review from timebertt

@plkokanov plkokanov Awaiting requested review from plkokanov

Assignees

@ary1992 ary1992

@plkokanov plkokanov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rfranzke @ary1992 @ialidzhikov @plkokanov