Extend ConditionBuilder interface with a WithClock(...) function

[oliver-goetz]

How to categorize this PR?

/area dev-productivity
/kind enhancement|

What this PR does / why we need it:
This PR extends ConditionBuilder interface with a WithClock(...) function as suggested in the linked issue.
Additionally, new ...WithClock(...) condition helper function are introduced. In the final step, those functions replace the existing helper functions, wherever a clock is available.

Which issue(s) this PR fixes:
Fixes #6689

Special notes for your reviewer:

Release note:

ConditionBuilder interface is extended by a `WithClock(...)` function.
`...WithClock(...)` condition helper functions are introduced.
`WithNowFunc(...)` function is removed from ConditionBuilder interface.

[gardener-prow]

@oliver-goetz: The label(s) kind/enhancement| cannot be applied, because the repository doesn't have them.

In response to this:

How to categorize this PR?

/area dev-productivity
/kind enhancement|

What this PR does / why we need it:
This PR extends ConditionBuilder interface with a WithClock(...) function as suggested in the linked issue.
Additionally, new ...WithClock(...) condition helper function are introduced. In the final step, those functions replace the existing helper functions, wherever a clock is available.

Which issue(s) this PR fixes:
Fixes #6689

Special notes for your reviewer:

Release note:

ConditionBuilder interface is extended by a `WithClock(...)` function.
`...WithClock(...)` condition helper functions are introduced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oliver-goetz]

/retitle Extend ConditionBuilder interface with a WithClock(...) function
/kind kind/enhancement

[gardener-prow]

@oliver-goetz: The label(s) kind/kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

/retitle Extend ConditionBuilder interface with a WithClock(...) function
/kind kind/enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oliver-goetz]

/kind enhancement

[oliver-goetz]

/cc @plkokanov

[rfranzke]

PR looks great now :) Only remaining open question is #6729 (comment)

[rfranzke]

/lgtm
/approve

[gardener-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rfranzke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gardener-prow]

@oliver-goetz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gardener-check-vulnerabilities	be45be9	link	false	/test pull-gardener-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rfranzke]

/lgtm