Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update machines crd #6779

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

rishabh-11
Copy link
Contributor

@rishabh-11 rishabh-11 commented Oct 6, 2022

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:
This PR is about the issue raised on mcm which can be seen here. This will update gardener to use the latest machine crd, allowing the display of node name and providerID when listing machines. The output is as follows:
Screenshot 2022-10-05 at 6 49 10 PM

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
The testing was done using the local kind setup of gardener.
Release note:

Updated machine CRD, allowing the display of node name and providerID(using -owide flag) when listing machines in the control plane of the shoot

@gardener-prow gardener-prow bot added area/usability Usability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 6, 2022
@rishabh-11
Copy link
Contributor Author

/invite @himanshu-kun

Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: himanshu-kun, rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@acumino acumino added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 6, 2022
@gardener-prow gardener-prow bot merged commit d733449 into gardener:master Oct 6, 2022
@rishabh-11 rishabh-11 deleted the update-machines-crd branch October 6, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants