-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added checks for non-gardener managed seed clusters to ensure correct seed configurations. #6782
Added checks for non-gardener managed seed clusters to ensure correct seed configurations. #6782
Conversation
… seed configurations. Clusters managed by gardener embed information about the node, pod and service networks inside the cluster as a config map. Other kubernetes clusters do not offer this information in a standard way. To ensure that the seed configuration fits to the reality of the seed cluster this change introduces a heuristic check that the configured node network is valid for the nodes seen in the cluster. The same applies to the pods and services. (The amount of entities being checked is limited so that large clusters do not delay the gardenlet start-up too much.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
Thanks, looks good, just a few nits
@ScheererJ: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area networking
/area quality
/kind technical-debt
What this PR does / why we need it:
Added checks for non-gardener managed seed clusters to ensure correct seed configurations.
Clusters managed by gardener embed information about the node, pod and service networks inside the cluster as a config map. Other kubernetes clusters do not offer this information in a standard way.
To ensure that the seed configuration fits to the reality of the seed cluster this change introduces a heuristic check that the configured node network is valid for the nodes seen in the cluster. The same applies to the pods and services. (The amount of entities being checked is limited so that large clusters do not delay the gardenlet start-up too much.)
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Having the seed configuration diverge from the seed cluster reality can lead to hard to track down issues with network policies as some of the ranges are taken from the seed configuration.
Release note: