Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gardenlet] Switch extensions controller to controller-runtime #6801

Merged
merged 12 commits into from
Oct 14, 2022

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area dev-productivity scalability
/kind enhancement

What this PR does / why we need it:
Refactor the extensions controller to controller-runtime. It consists of two reconcilers, so there are some empty separator commits to allow easy navigation through the PR.

Instead of keeping the old structure, it is now as follows:

  • The "ControllerInstallation Required" reconciler was moved to pkg/gardenlet/controller/controllerinstallation/required
  • The "ShootState Extensions Sync" reconciler was moved to pkg/gardenlet/controller/shootstate/extensions

Which issue(s) this PR fixes:
Part of #4251

Special notes for your reviewer:
Generally, we want to follow this cookbook while refactoring existing controllers:

  1. Add documentation
  2. Add integration test based on envtest (if not already present)
  3. Switch controller to controller-runtime

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) area/scalability Scalability related labels Oct 11, 2022
@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 11, 2022
@rfranzke
Copy link
Member Author

  • The "ShootState Extensions Sync" reconciler was moved to pkg/gardenlet/controller/shootstate/extensions

cc @acumino for the refactoring of the shootsecret controller: Please keep this structure, i.e. move it to pkg/gardenlet/controller/shootstate/secret.

@acumino acumino self-assigned this Oct 12, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 14, 2022

@rfranzke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dependency-watchdog-verify-image-build b34ccc2 link true /test pull-dependency-watchdog-verify-image-build
pull-gardener-check-vulnerabilities 845523f link false /test pull-gardener-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@rfranzke
Copy link
Member Author

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@gardener-prow gardener-prow bot merged commit 98c30a3 into gardener:master Oct 14, 2022
@rfranzke rfranzke deleted the refactor/extension-ctrl branch October 14, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/scalability Scalability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants