-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gardenlet] Switch extensions controller to controller-runtime
#6801
[gardenlet] Switch extensions controller to controller-runtime
#6801
Conversation
cc @acumino for the refactoring of the |
9199130
to
b34ccc2
Compare
test/integration/gardenlet/controllerinstallation/required/required_test.go
Show resolved
Hide resolved
- Reconcile when operation annotation gets changed - Skip reconciliations for invalid operation annotations via predicate - Remove state from ShootState when object has deletion timestamp
…r-runtime controller
b34ccc2
to
845523f
Compare
@rfranzke: The following tests failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area dev-productivity scalability
/kind enhancement
What this PR does / why we need it:
Refactor the extensions controller to
controller-runtime
. It consists of two reconcilers, so there are some empty separator commits to allow easy navigation through the PR.Instead of keeping the old structure, it is now as follows:
ControllerInstallation
Required" reconciler was moved topkg/gardenlet/controller/controllerinstallation/required
ShootState
Extensions Sync" reconciler was moved topkg/gardenlet/controller/shootstate/extensions
Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Generally, we want to follow this cookbook while refactoring existing controllers:
envtest
(if not already present)controller-runtime
Release note: