Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gardener.cloud/purpose: kube-system label to all seeds #6829

Merged

Conversation

bd3lage
Copy link
Contributor

@bd3lage bd3lage commented Oct 13, 2022

How to categorize this PR?

/area control-plane
/kind task

What this PR does / why we need it:

Make sure ALL seeds have the label gardener.cloud/purpose: kube-system for kube-system namespace
(to prevent our webhooks that already exclude above label from interfering; our managed seeds have this label automatically but unmanaged seeds not)

Which issue(s) this PR fixes:
Fixes landscape-stability issue#39

Special notes for your reviewer:

Release note:

The `gardener.cloud/purpose: kube-system` label is now added to the `kube-system` namespace by the `gardenlet'`s `Seed` controller.

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 13, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/control-plane Control plane related kind/task General task cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Oct 13, 2022
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2022
@rfranzke
Copy link
Member

Why is this PR still in draft mode?

@bd3lage bd3lage marked this pull request as ready for review October 14, 2022 12:43
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2022
@gardener-prow gardener-prow bot requested a review from rfranzke October 14, 2022 12:43
@bd3lage bd3lage force-pushed the seed_kube-system_purpose_label branch from 779a6e6 to da96e86 Compare October 14, 2022 12:54
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 14, 2022

@bd3lage: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dependency-watchdog-verify-image-build 779a6e6 link true /test pull-dependency-watchdog-verify-image-build
pull-gardener-check-vulnerabilities da96e86 link false /test pull-gardener-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@gardener-prow gardener-prow bot merged commit 194e84b into gardener:master Oct 14, 2022
@bd3lage bd3lage deleted the seed_kube-system_purpose_label branch October 20, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/task General task lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants