-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable log level/format for gardener-resource-manager #6830
Configurable log level/format for gardener-resource-manager #6830
Conversation
a1098c2
to
20d0930
Compare
@oliver-goetz: The following tests failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Same here for GRM
|
This seems to be an issue with the HA e2e tests. They do not use the local built gardener-core images, but the latest dev version from eu.gcr.io
|
Ahhh I see, the image vector overwrites are not set for HA e2e tests in skaffold.yaml |
Awesome, thanks @oliver-goetz for checking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
This PR creates cli parameters
--log-level=<debug/info/error>
and--log-format=<json/text>
in gardener-resource-manager and enables their configuration in gardener-control-plane helm chart andbotanist
package.The later does not include a dedicated configuration for gardener-resource-manager and this PR does not create one for this purpose only. This is the log-level/format configurations:
When running on Seed clusters:
log-level and log-format settings of gardenlet are used for gardener-controller-manager too
When running on Shoot clusters:
There are default values only
--log-level=info
--log-format=json
In both scenarios different log-levels/format could be set by changing their deployments while ignoring the corresponding managed resource during reconciliation.
Which issue(s) this PR fixes:
Part of #5191
Special notes for your reviewer:
This PR adds a verification of log-levels and log-format for gardener-apiserver which was forgotten in #6817
Release note: