-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jq --compact-output
option in the binding update command
#6843
Conversation
After digging some more, Using
|
85e7ef6
to
238f6fa
Compare
@shafeeqes: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: plkokanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area control-plane-migration
/kind bug
What this PR does / why we need it:
After #6727, the command
gardener/docs/usage/control_plane_migration.md
Line 34 in 779f0bf
throws error:
After checking what's the spec change, it's only how it is represented by
jq
.This PR adds
-c
or--compact-output
to the jq command, so that the expected and provided format remains same.I have also added a validation to reject the update of
binding
if seedName is same.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @plkokanov
Release note: