[gardenlet] Switch NetworkPolicy controller to controller-runtime
#6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
76 tasks
rfranzke
requested changes
Nov 11, 2022
test/integration/gardenlet/networkpolicy/networkpolicy_suite_test.go
Outdated
Show resolved
Hide resolved
test/integration/gardenlet/networkpolicy/networkpolicy_suite_test.go
Outdated
Show resolved
Hide resolved
test/integration/gardenlet/networkpolicy/networkpolicy_suite_test.go
Outdated
Show resolved
Hide resolved
shafeeqes
reviewed
Nov 11, 2022
gardener-prow
bot
added
size/XXL
oliver-goetz
force-pushed
the
enh/network-policy-controller-refactoring
branch
from
6eccd03
to
baa938f
Compare
rfranzke
requested changes
Nov 14, 2022
oliver-goetz
force-pushed
the
enh/network-policy-controller-refactoring
branch
from
3115c30
to
29d613f
Compare
rfranzke
reviewed
Nov 15, 2022
There was a problem hiding this comment.
No further comments, thanks @oliver-goetz
/approve
@shafeeqes anything else from your end?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity scalability
/kind enhancement
What this PR does / why we need it:
This PR refactors
NetworkPolicycontroller tocontroller-runtime.Additionally, the reconciler now compares the entire spec of the
NetworkPolicyinstead of egress rules only to determine if something changed.Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Generally, we want to follow this cookbook while refactoring existing controllers:
envtest(if not already present)controller-runtimeRelease note: