[gardenlet] Switch ManagedSeed controller to controller-runtime
#7108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
gardener-prow
bot
added
do-not-merge/work-in-progress
gardener-prow
bot
added
the
size/XXL
ary1992
changed the title
ManagedSeed controller to controller-runtime
76 tasks
ary1992
force-pushed
the
refactor/managedseed-ctrl
branch
from
ae1bbe4
to
6a9fbd3
Compare
gardener-prow
bot
removed
the
needs-rebase
shafeeqes
requested changes
Nov 30, 2022
test/integration/gardenlet/managedseed/managedseed_suite_test.go
Outdated
Show resolved
Hide resolved
test/integration/gardenlet/managedseed/managedseed_suite_test.go
Outdated
Show resolved
Hide resolved
test/integration/gardenlet/managedseed/managedseed_suite_test.go
Outdated
Show resolved
Hide resolved
shafeeqes
reviewed
Dec 1, 2022
ary1992
force-pushed
the
refactor/managedseed-ctrl
branch
from
b31cb53
to
f89b68d
Compare
|
/test all |
shafeeqes
reviewed
Dec 2, 2022
ary1992
force-pushed
the
refactor/managedseed-ctrl
branch
from
f89b68d
to
2853fd2
Compare
|
/test all |
gardener-prow
bot
added
the
needs-rebase
With this changes garden namespace validation can be disabled by disabling the ManagedSeed plugin for integrations test. In the next commit namespace will be passed as an argument to controller.
This is done for assigning a unique garden namespace in case if integration test.
- enqueue with jitter delay logic from managed seed controller is moved to controllerutils. - in the later commit jitter delay logic is removed from controller and instead EnqueueWithJitterDelay function is used.
…to controller and not a generic function
ary1992
force-pushed
the
refactor/managedseed-ctrl
branch
from
80fc489
to
c101c4b
Compare
shafeeqes
reviewed
Dec 14, 2022
test/integration/gardenlet/managedseed/managedseed_suite_test.go
Outdated
Show resolved
Hide resolved
shafeeqes
reviewed
Dec 14, 2022
rfranzke
changed the title
ManagedSeed controller to controller-runtimeManagedSeed controller to controller-runtime
rfranzke
reviewed
Dec 14, 2022
rfranzke
reviewed
Dec 14, 2022
- Added `ShootClientMap` and `ImageVector` to the Reconciler struct. - Removed `RateLimiter` from Reconciler struct as it is not needed here. - Renamed `SeedOfManagedSeedFilterPredicate` to `SeedOfManagedSeedPredicate` - Renamed `ManagedSeedFilterPredicate` to `ManagedSeedPredicate` - GardenletConfiguration is passed in Reconciler struct instead of `ManagedSeedControllerConfiguration`
ary1992
force-pushed
the
refactor/managedseed-ctrl
branch
from
50d6a38
to
6c299cf
Compare
|
/test pull-gardener-unit |
|
@ary1992: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
LGTM label has been added. Git tree hash: 260ebba6aa7c9f623a71dbb18f3f84ee80131289
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shafeeqes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
seshachalam-yv
pushed a commit
to seshachalam-yv/gardener
that referenced
this pull request
Dec 26, 2022
…ardener#7108) * Move garden namespace validation of ManagedSeed to ManagedSeed plugins With this changes garden namespace validation can be disabled by disabling the ManagedSeed plugin for integrations test. In the next commit namespace will be passed as an argument to controller. * Pass garden namespace and chart path as an argument to controller This is done for assigning a unique garden namespace in case if integration test. * Adapt configurable garden namespace in gardenlet charts * Integration test * Move EnqueueWithJitterDelay function to controllerutils - enqueue with jitter delay logic from managed seed controller is moved to controllerutils. - in the later commit jitter delay logic is removed from controller and instead EnqueueWithJitterDelay function is used. * Switch ManagedSeed controller to native controller-runtime * Adapt unit and integration tests * Improve integration test [Delete case] * Address PR review feedback * Address PR review feedback * Fix e2e test * Introduce garden namespace for garden and garden namespace for shoot in the controller - this is done to allow passing created namespace for shoot and garden instead of using hardcoded garden namespace for integration test. * Move EnqueueWithJitterDelay function to controller as it is specific to controller and not a generic function * Fix integration test * Remove ControlledResourceEventHandler as it no longer used anywhere * Address PR review feedback * Address PR review feedback - Added `ShootClientMap` and `ImageVector` to the Reconciler struct. - Removed `RateLimiter` from Reconciler struct as it is not needed here. - Renamed `SeedOfManagedSeedFilterPredicate` to `SeedOfManagedSeedPredicate` - Renamed `ManagedSeedFilterPredicate` to `ManagedSeedPredicate` - GardenletConfiguration is passed in Reconciler struct instead of `ManagedSeedControllerConfiguration` * Rename file and minor Nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity scalability
/kind enhancement
What this PR does / why we need it:
Refactor the
ManagedSeedcontroller to controller-runtime.Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Generally, we want to follow this cookbook while refactoring existing controllers:
Add documentation
Add integration test based on envtest (if not already present)
Switch controller to controller-runtime
Release note: