-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gardenlet] Refactor handling of Shoot
main controller special cases
#7189
[gardenlet] Refactor handling of Shoot
main controller special cases
#7189
Conversation
/assign |
/assign |
This PR should go into the v1.62.0 release. Otherwise, the |
@timebertt: You must be a member of the gardener/gardener-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ary1992 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we did a joint review with @ary1992
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @timebertt for the joint work on this, enjoyed it.
/lgtm
/approve
Thanks for the fast review, PTAL :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
28d1e7c
to
78026ac
Compare
/unassign |
78026ac
to
a24c415
Compare
Sorry folks, something went wrong during the rebase. It should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com>
a24c415
to
75833b7
Compare
@timebertt: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Shoot
main controller special cases
Kudos @timebertt and @rfranzke for touching this spaceship 👨🚀 Nice PR! |
How to categorize this PR?
/area dev-productivity quality
/kind technical-debt
What this PR does / why we need it:
Previously, special cases for confined and jittered shoot reconciliations (see docs) were handled by a few lines of boolean variable combinations, and the reconciliation due tracker.
We faced some bugs and regressions in this logic because it was not covered by tests at all, was not readable, and was not documented at all.
However, this logic is quite important for the stability of large-scale gardener installations.
This PR refactors this logic to make it more readable and well-documented and adds full unit test coverage.
Additionally, we can now use the helpers in both the shoot main reconciler and its event handler.
This allows us to use
AddAfter
in the event handler, instead of performing a reconciliation that will exit early withRequeueAfter
(and allows us to get rid of the reconciliation due tracker).Co-Authored-By @rfranzke
Which issue(s) this PR fixes:
Follow-up on #7082
Part of #4251
Special notes for your reviewer:
Release note: