Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP-21] Regenerate TOC #7227

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[GEP-21] Regenerate TOC #7227

merged 1 commit into from
Dec 19, 2022

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area enhancement
/kind networking

What this PR does / why we need it:
We missed updating the TOC for the latest changes in #7050.

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Dec 19, 2022

@timebertt: The label(s) area/enhancement, kind/networking cannot be applied, because the repository doesn't have them.

In response to this:

How to categorize this PR?

/area enhancement
/kind networking

What this PR does / why we need it:
We missed updating the TOC for the latest changes in #7050.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2022
@timebertt
Copy link
Member Author

/area networking
/kind enhancement

@gardener-prow gardener-prow bot added area/networking Networking related kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 19, 2022
@timebertt
Copy link
Member Author

/retest-required

rfranzke
rfranzke reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Dec 19, 2022

LGTM label has been added.

Git tree hash: 7a15ce28a2d841fab292ecbafb64038e21d1d162

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
@gardener-prow gardener-prow bot merged commit 759c264 into gardener:master Dec 19, 2022
@timebertt timebertt deleted the gep21-toc branch December 19, 2022 08:16
seshachalam-yv pushed a commit to seshachalam-yv/gardener that referenced this pull request Dec 26, 2022
@timebertt @seshachalam-yv
[GEP-21] Regenerate TOC (gardener#7227)
921f46b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@acumino acumino Awaiting requested review from acumino

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking Networking related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timebertt @rfranzke