Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce seed zones admission checks #7403

Merged

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Jan 28, 2023

How to categorize this PR?

/area high-availability
/kind api-change
/kind technical-debt

What this PR does / why we need it:
This PR reintroduces admission checks for seed zones, removed by 8d28452. In the meantime, the Azure provider extension can deal with a zone mismatch on its own, see gardener/gardener-extension-provider-azure#602.

Which issue(s) this PR fixes:
Part of #6529

Special notes for your reviewer:
/cc @kon-angelo

Release note:

`Seed` and `ManagedSeed` API validation has been enhanced by the following checks:
(a) `ManagedSeed`s can only use the very same zone(s) (`managedSeed.spec.gardenlet.config.seedConfig.spec.provider.zones`) that are available in the registered `Shoot` (`shoot.spec.provider.workers[].zones`).
(b) `seed.spec.provider.zones` can only be removed if no shoots are scheduled to affected seed.
These restrictions were removed in Gardener `v1.60` to compensate a zone mismatch issues in Azure that is in the meantime fixed by the Azure provider extension [v1.33](https://github.com/gardener/gardener-extension-provider-azure/releases/tag/v1.33.0).
⚠️ Before upgrading to this Gardener version, please make sure the zone configuration of your seeds matches the ones from registered shoots, i.e. `seed.spec.provider.zones == shoot.spec.provider.workers[].zones`.

@gardener-prow gardener-prow bot added area/high-availability High availability related kind/api-change API change with impact on API users kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2023
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @kon-angelo

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jan 31, 2023

LGTM label has been added.

Git tree hash: b837c5e77afe6d9801cd903138d8312a16e5948b

@kon-angelo
Copy link
Contributor

kon-angelo commented Jan 31, 2023

/lgtm

In the removal PR there were some additional tests for the miscellaneous.go file that can probably be reused.
You can notify me for azure headaches/bugs but it should work now.

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@gardener-prow gardener-prow bot requested a review from rfranzke February 1, 2023 07:37
@rfranzke
Copy link
Member

rfranzke commented Feb 1, 2023

@kon-angelo I've added the missing tests from the linked commit again with bf8edc2.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 1, 2023

LGTM label has been added.

Git tree hash: c22df0db59b6d49cf50636620977f3510675ff8d

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 1, 2023

@timuthy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-e2e-kind-ha-single-zone-upgrade bf8edc2 link false /test pull-gardener-e2e-kind-ha-single-zone-upgrade
pull-gardener-e2e-kind-ha-multi-zone-upgrade bf8edc2 link false /test pull-gardener-e2e-kind-ha-multi-zone-upgrade

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rfranzke
Copy link
Member

rfranzke commented Feb 1, 2023

/test pull-gardener-integration

@gardener-prow gardener-prow bot merged commit 376ea52 into gardener:master Feb 1, 2023
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
* Reintroduce seed zones admission checks

* Add missing tests

---------

Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/high-availability High availability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/api-change API change with impact on API users kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants