-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce seed zones admission checks #7403
Reintroduce seed zones admission checks #7403
Conversation
01f7b58
to
54e1c97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @kon-angelo
LGTM label has been added. Git tree hash: b837c5e77afe6d9801cd903138d8312a16e5948b
|
/lgtm In the removal PR there were some additional tests for the |
@kon-angelo I've added the missing tests from the linked commit again with bf8edc2. /lgtm |
LGTM label has been added. Git tree hash: c22df0db59b6d49cf50636620977f3510675ff8d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@timuthy: The following tests failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-gardener-integration |
* Reintroduce seed zones admission checks * Add missing tests --------- Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
How to categorize this PR?
/area high-availability
/kind api-change
/kind technical-debt
What this PR does / why we need it:
This PR reintroduces admission checks for seed zones, removed by 8d28452. In the meantime, the Azure provider extension can deal with a zone mismatch on its own, see gardener/gardener-extension-provider-azure#602.
Which issue(s) this PR fixes:
Part of #6529
Special notes for your reviewer:
/cc @kon-angelo
Release note: