Prepare for the removal of the enableBasicAuthentication field
#7534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
kind/cleanup
gardener-prow
bot
added
the
size/L
11 tasks
gardener-prow
bot
added
the
needs-rebase
ialidzhikov
force-pushed
the
cleanup/basic-auth-field
branch
from
e791179
to
3fd318a
Compare
gardener-prow
bot
added
cla: no
ialidzhikov
force-pushed
the
cleanup/basic-auth-field
branch
from
ad70204
to
3fd318a
Compare
|
/assign |
rfranzke
reviewed
Feb 23, 2023
gardener-prow
bot
added
the
needs-rebase
Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com>
Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com>
…pareForCreate and PrepareForUpdate Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com>
The field is now no-op. Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com>
Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com>
…anifest used by test machinery Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com>
…value is `basic` Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com>
ialidzhikov
force-pushed
the
cleanup/basic-auth-field
branch
from
3fd318a
to
a14ff33
Compare
gardener-prow
bot
removed
the
needs-rebase
|
@ialidzhikov: The following tests failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 3ffb27ec8b54336f3ab5f1aa9d647a8b97255a28
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
andrerun
pushed a commit
to andrerun/gardener
that referenced
this pull request
Jul 6, 2023
…dener#7534) * Remove the validation for the `enableBasicAuthentication` field Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com> * Remove the defaulting for the `enableBasicAuthentication` field Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com> * Set the `enableBasicAuthentication` field to nil in shootStrategy PrepareForCreate and PrepareForUpdate Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com> * Update the doc string of the `enableBasicAuthentication` field The field is now no-op. Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com> * Remove the unused helper function Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com> * Remove the `enableBasicAuthentication` field from the default Shoot manifest used by test machinery Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com> * Set `kubernetesDashboard.authenticationMode` field to `token` if its value is `basic` Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com> * Drop the `KubernetesDashboardAuthModeBasic` const --------- Co-authored-by: dimitar-kostadinov <dimitar.kostadinov@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind cleanup
What this PR does / why we need it:
The
enableBasicAuthenticationfield does no longer make sense after #6987. In #6987 we removed support for Shoots with K8s < 1.20. The basic authentication was removed in K8s 1.19.x. Hence, it is not possible to enable basic auth anymore for a Shoot that is within the support K8s versions of Gardener currently.This PR is a preparation for the removal of the
enableBasicAuthenticationfield:enableBasicAuthenticationfield no-op (removes validation, removes defaulting) - the field is not used anymore.enableBasicAuthenticationfield always to nil. So far the field was always defaulted to false, if it was not specified in the field..spec.kubernetes.addons.kubernetesDashboard.authenticationModetotoken, if it is set tobasic.Which issue(s) this PR fixes:
Part of #6911
Special notes for your reviewer:
N/A
Release note: