Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.64] Fix secret manager adoption of existing secrets #7718

Conversation

gardener-ci-robot
Copy link
Contributor

This is an automated cherry-pick of #7710

/assign rfranzke

A bug has been fixed which prevented existing secrets from being adopted when they were named `kube-apiserver-etcd-encryption-key` or `service-account-key`.

Co-Authored-By: Tim Usner <tim.usner@sap.com>
@gardener-prow gardener-prow bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Mar 27, 2023
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2023
@rfranzke
Copy link
Member

/lgtm
/kind bug
/approve

@gardener-prow gardener-prow bot added kind/bug Bug lgtm Indicates that a PR is ready to be merged. labels Mar 27, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 27, 2023

LGTM label has been added.

Git tree hash: 2e5250414d3df59a43dee0f209919cc30f06b9b9

@gardener-prow gardener-prow bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Mar 27, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@gardener-prow gardener-prow bot merged commit dcf0717 into gardener:release-v1.64 Mar 27, 2023
@oliver-goetz oliver-goetz deleted the cherry-pick-7710-to-release-v1.64 branch April 21, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants