Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock the Seed's .spec.settings.ownerChecks.enabled field to false #7909

Merged
merged 2 commits into from May 22, 2023
Merged

Lock the Seed's .spec.settings.ownerChecks.enabled field to false #7909

merged 2 commits into from May 22, 2023

Conversation

dimitar-kostadinov
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov commented May 10, 2023 •
edited by ialidzhikov

How to categorize this PR?

/area control-plane-migration
/kind cleanup

What this PR does / why we need it:
Prevents owner checks enablement. Seeds' .spec.settings.ownerChecks.enabled field is locked to false (i.e. if the field value is true a validation error will be returned).

Which issue(s) this PR fixes:
Part of #6302

Special notes for your reviewer:
N/A

Release note:

⚠️ Seeds' `.spec.settings.ownerChecks.enabled` field is locked to `false` (i.e. if the field value is true a validation error will be returned). Before updating to this version of Gardener, set `.spec.settings.ownerChecks.enabled` field to `false` for you Seeds and ManagedSeeds.

The `{github.com/gardener/gardener/pkg/apis/core/helper,github.com/gardener/gardener/pkg/apis/core/v1beta1/helper}.SeedSettingOwnerChecksEnabled` will now return `false` if the corresponding Seed setting is `nil`. Previously, the func was returning `true` when the Seed setting is `nil`.

The unused `github.com/gardener/gardener/pkg/controllerutils/predicate.IsBeingMigratedPredicate`, `github.com/gardener/gardener/pkg/controllerutils/predicate.IsObjectBeingMigrated` and `github.com/gardener/gardener/pkg/utils/gardener.IsObjectBeingMigrated` funcs are now removed.

@gardener-prow gardener-prow bot added area/control-plane-migration Control plane migration related kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2023
@gardener-prow gardener-prow bot requested review from acumino and ary1992 May 10, 2023 09:50
@ialidzhikov
Copy link
Member

/assign

@ialidzhikov ialidzhikov mentioned this pull request May 12, 2023
Closed
31 tasks
Kostov6
Kostov6 reviewed May 16, 2023
View reviewed changes
pkg/apis/core/validation/seed.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/seed_test.go Outdated Show resolved Hide resolved
ialidzhikov
ialidzhikov reviewed May 16, 2023
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @Kostov6 we tested in local setup that the change behaves as expected.

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@dimitar-kostadinov dimitar-kostadinov force-pushed the lock-owner-checks-to-false branch 2 times, most recently from f8e0353 to abe95ee Compare May 17, 2023 07:41
ialidzhikov
ialidzhikov reviewed May 17, 2023
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 17, 2023

LGTM label has been added.

Git tree hash: f4f608095999b856659b9c1bfd15c53171d99383

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@gardener-prow gardener-prow bot requested a review from ialidzhikov May 17, 2023 11:51
ialidzhikov
ialidzhikov reviewed May 17, 2023
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 17, 2023

LGTM label has been added.

Git tree hash: c6f5b55a63f580047070a61684f9e2a97f3e77ff

@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels May 17, 2023
@ialidzhikov ialidzhikov changed the title Prevent owner checks enablement Lock the Seed's .spec.settings.ownerChecks.enabled field to false May 17, 2023
@dimitar-kostadinov dimitar-kostadinov mentioned this pull request May 17, 2023
Merged
@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 22, 2023 •
edited

@dimitar-kostadinov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff 238ba9c link false /test pull-gardener-apidiff

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shafeeqes
Copy link
Contributor

/test pull-gardener-e2e-kind

@gardener-prow gardener-prow bot merged commit 392dd7b into gardener:master May 22, 2023
15 of 16 checks passed
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
@dimitar-kostadinov @andrerun
Lock the Seed's .spec.settings.ownerChecks.enabled field to false (…
4de3ebf 
…gardener#7909)

* Prevent owner checks enablement

* Cleanup obsolete IsBeingMigratedPredicate predicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov left review comments

@Kostov6 Kostov6 Kostov6 left review comments

@acumino acumino Awaiting requested review from acumino

@ary1992 ary1992 Awaiting requested review from ary1992

Assignees

@ialidzhikov ialidzhikov

@Kostov6 Kostov6

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-migration Control plane migration related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dimitar-kostadinov @ialidzhikov @shafeeqes @Kostov6