Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.68] Don't allow shoot to scale up to HA if it is hibernated #7922

Merged
merged 10 commits into from
May 11, 2023
Merged

[release-v1.68] Don't allow shoot to scale up to HA if it is hibernated #7922

merged 10 commits into from
May 11, 2023

Conversation

gardener-ci-robot
Copy link
Contributor

This is an automated cherry-pick of #7894

/assign aaronfern

Gardener denies setting `Shoot.Spec.ControlPlane.HighAvailability.FailureTolerance.Type` if shoot is hibernated.

@gardener-ci-robot gardener-ci-robot mentioned this pull request May 11, 2023
Merged
@gardener-prow gardener-prow bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 11, 2023
@gardener-prow gardener-prow bot requested review from ary1992 and timuthy May 11, 2023 11:17
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2023
@shafeeqes
Copy link
Contributor

/kind enhancement
/lgtm
/approve

@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension labels May 11, 2023
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 11, 2023

LGTM label has been added.

Git tree hash: 48165e3147958d90e75ce75a7f968a29889c24bc

@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shafeeqes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 11, 2023
@shafeeqes
Copy link
Contributor

/retest-required

@gardener-prow gardener-prow bot merged commit 15c437a into gardener:release-v1.68 May 11, 2023
13 of 14 checks passed
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-7894-to-release-v1.68 branch July 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ary1992 ary1992 Awaiting requested review from ary1992

@timuthy timuthy Awaiting requested review from timuthy

Assignees

@shafeeqes shafeeqes

@aaronfern aaronfern

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gardener-ci-robot @shafeeqes @aaronfern