Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain feature gates #8008

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Jun 1, 2023

How to categorize this PR?

/area dev-productivity open-source
/kind enhancement

What this PR does / why we need it:

  • Drop GA-ed SeedChange feature gate
  • Drop GA-ed CopyEtcdBackupsDuringControlPlaneMigration feature gate
  • Promote FullNetworkPolicies feature gate to GA
  • Promote HAControlPlanes feature gate to GA

Which issue(s) this PR fixes:
Part of #7352
Part of #6529

Release note:

The GA-ed feature gates `SeedChange` and `CopyEtcdBackupsDuringControlPlaneMigration` have been removed.
The feature gates `FullNetworkPolicies` and `HAControlPlanes` have been promoted to GA and are now locked to "unconditionally enabled".

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related labels Jun 1, 2023
@gardener-prow gardener-prow bot requested review from ary1992 and shafeeqes June 1, 2023 06:53
@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 1, 2023
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 6, 2023

LGTM label has been added.

Git tree hash: 65f0f61bc862435f500a79f4539295fb06f9a24a

Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Looks good.

/lgtm

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@gardener-prow gardener-prow bot merged commit 90fe690 into gardener:master Jun 6, 2023
16 checks passed
@rfranzke rfranzke deleted the cleanup/featuregates branch June 9, 2023 05:54
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
* Drop GA-ed `SeedChange` feature gate

* Drop GA-ed `CopyEtcdBackupsDuringControlPlaneMigration` feature gate

* Promote `FullNetworkPolicies` feature gate to GA

* Promote `HAControlPlanes` feature gate to GA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants