Allow reuse of the functionality that checks for skaffold dependencies #8630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
gardener-prow
bot
added
the
size/L
96 tasks
plkokanov
requested changes
Oct 10, 2023
|
/test pull-gardener-e2e-kind |
|
/lgtm |
|
LGTM label has been added. Git tree hash: cadc7d98d9035830aad539711ce2fbd24dbb497d
|
ialidzhikov
force-pushed
the
enh/check-skaffold-deps
branch
from
22c4acd
to
c592b8b
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 50d19442ec61dc2dd7e2928106b2b5a84a29e98f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: plkokanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-registry-cache
that referenced
this pull request
Nov 13, 2023
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-registry-cache
that referenced
this pull request
Nov 13, 2023
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-registry-cache
that referenced
this pull request
Nov 15, 2023
gardener-prow bot
pushed a commit
to gardener/gardener-extension-registry-cache
that referenced
this pull request
Nov 16, 2023
* go.mod: Update github.com/gardener/gardener to v1.82.2 * make revendor * Clean up TODO related to the skaffold version After gardener/gardener#8634 we no longer need to overwrite the skaffold version * Use the `hack/check-skaffold-deps-for-binary.sh` from Gardener scripts See gardener/gardener#8630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:
In the registry-cache extension we also had to specify ko dependencies in the skaffold file to workaround GoogleContainerTools/skaffold#7836. See gardener/gardener-extension-registry-cache#57.
We also forked the
hack/check-skaffold-deps.shscript and adapted it for us.This PR makes possible reuse of the core logic so that other extensions using skaffold (such as shoot-rsyslog-relp extension, cc @plkokanov) can easily reuse the logic for checking skaffold deps.
Which issue(s) this PR fixes:
Part of gardener/gardener-extension-registry-cache#3
Special notes for your reviewer:
See example usage in ialidzhikov/gardener-extension-registry-cache@7f47b4b
Release note: