Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for backup infra controller redesign #932

Merged
merged 1 commit into from Apr 17, 2019

Conversation

swapnilgm
Copy link

Signed-off-by: Swapnil Mhamane swapnil.mhamane@sap.com

What this PR does / why we need it:
This PR include the design proposal for gardener/etcd-backup-restore#141.
Main goal is to use shared backup bucket among shoots. Things are explained in proposal docs in details.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
As per internal discussion we (@amshuman-kr @vlerenc @shreyas-s-rao )agree on it. And it is ready to be implemented. Please feel free to suggest any changes considering the extensibility proposal.

Release note:

NONE

@swapnilgm swapnilgm requested a review from a team as a code owner April 16, 2019 06:39
@rfranzke rfranzke added area/disaster-recovery Disaster recovery related area/documentation Documentation related exp/expert kind/enhancement Enhancement, improvement, extension platform/all size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topology/seed Affects Seed clusters labels Apr 16, 2019
@rfranzke rfranzke mentioned this pull request Apr 16, 2019
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: Very nice document!

docs/proposals/02-backupinfra.md Outdated Show resolved Hide resolved
docs/proposals/02-backupinfra.md Outdated Show resolved Hide resolved
docs/proposals/02-backupinfra.md Outdated Show resolved Hide resolved
docs/proposals/02-backupinfra.md Show resolved Hide resolved
docs/proposals/02-backupinfra.md Show resolved Hide resolved
docs/proposals/02-backupinfra.md Outdated Show resolved Hide resolved
docs/proposals/02-backupinfra.md Outdated Show resolved Hide resolved
docs/proposals/02-backupinfra.md Show resolved Hide resolved
docs/proposals/02-backupinfra.md Outdated Show resolved Hide resolved
Signed-off-by: Swapnil Mhamane <swapnil.mhamane@sap.com>
@swapnilgm
Copy link
Author

@rfranzke Thank you for the review. I have update the doc addressing your queries.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 142c6e4 into gardener:master Apr 17, 2019
@swapnilgm swapnilgm deleted the backup-infra-update branch July 8, 2020 04:49
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/disaster-recovery Disaster recovery related area/documentation Documentation related kind/enhancement Enhancement, improvement, extension platform/all size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topology/seed Affects Seed clusters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants