New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for backup infra controller redesign #932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfranzke
added
area/disaster-recovery
Disaster recovery related
area/documentation
Documentation related
exp/expert
kind/enhancement
Enhancement, improvement, extension
platform/all
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
topology/seed
Affects Seed clusters
labels
Apr 16, 2019
Merged
rfranzke
reviewed
Apr 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall: Very nice document!
swapnilgm
force-pushed
the
backup-infra-update
branch
from
April 16, 2019 10:53
0734d45
to
4fff0ca
Compare
Signed-off-by: Swapnil Mhamane <swapnil.mhamane@sap.com>
swapnilgm
force-pushed
the
backup-infra-update
branch
from
April 16, 2019 11:09
4fff0ca
to
298d0bf
Compare
@rfranzke Thank you for the review. I have update the doc addressing your queries. |
rfranzke
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
priority/3
Priority (lower number equals higher priority)
and removed
priority/3
Priority (lower number equals higher priority)
labels
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/disaster-recovery
Disaster recovery related
area/documentation
Documentation related
kind/enhancement
Enhancement, improvement, extension
platform/all
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
topology/seed
Affects Seed clusters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Swapnil Mhamane swapnil.mhamane@sap.com
What this PR does / why we need it:
This PR include the design proposal for gardener/etcd-backup-restore#141.
Main goal is to use shared backup bucket among shoots. Things are explained in proposal docs in details.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
As per internal discussion we (@amshuman-kr @vlerenc @shreyas-s-rao )agree on it. And it is ready to be implemented. Please feel free to suggest any changes considering the extensibility proposal.
Release note: