Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Drop VPN Diffie–Hellman parameters #9386

Merged
merged 4 commits into from Mar 26, 2024
Merged

[Cleanup] Drop VPN Diffie–Hellman parameters #9386

merged 4 commits into from Mar 26, 2024

Conversation

ary1992
Copy link
Contributor

@ary1992 ary1992 commented Mar 14, 2024 •
edited by ialidzhikov

How to categorize this PR?

/area quality
/kind cleanup

What this PR does / why we need it:
Drop no longer needed VPN Diffie–Hellman parameters. Vpn release v0.23.0 removed the need for supplying the vpn server with Diffie–Hellman parameters. Hence the related codes are dropped from our code-base.

vpn-seed-server-dh secret will be cleaned up the GRM garbage-collector controller as this secret has resources.gardener.cloud/garbage-collectable-reference: "true" label set.

Which issue(s) this PR fixes:
Fixes #9093

Special notes for your reviewer:

Release note:

Secret `vpn-seed-server-dh` will no longer be created as [gardener/vpn2](https://github.com/gardener/vpn2) release `v0.23.0` removed the need for supplying the vpn server with `Diffie–Hellman` parameters.

Secret `openvpn-diffie-hellman-key` in the `garden` namespace containing the Diffie-Hellmann key can be deleted from landscapes as it is no longer needed.

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up labels Mar 14, 2024
@gardener-prow gardener-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2024
@rfranzke
Copy link
Member

/assign

@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@ary1992 ary1992 marked this pull request as ready for review March 14, 2024 12:02
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2024
@gardener-prow gardener-prow bot requested a review from ScheererJ March 14, 2024 12:02
ScheererJ
ScheererJ reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 14, 2024

LGTM label has been added.

Git tree hash: 3dabc679420d3f851c28f74f840674a5bc646d0f

@ScheererJ
Copy link
Contributor

Could you please check the tests and run make generate?

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
@gardener-prow gardener-prow bot requested a review from ScheererJ March 14, 2024 14:57
rfranzke
rfranzke requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete https://github.com/gardener/gardener/blob/master/example/10-secret-openvpn-diffie-hellman.yaml and adapt

gardener/docs/operations/configuration.md

Line 75 in 932601d

* **OpenVPN Diffie-Hellmann Key secret** (optional) - contains the self-generated Diffie-Hellmann key used by OpenVPN in your landscape, please see this [yaml file](../../example/10-secret-openvpn-diffie-hellman.yaml) for an example.
?

@rfranzke
Copy link
Member

Also, please adapt the release note for operators (i.e., they can delete this secret from garden namespace, etc.)

@ary1992 ary1992 requested a review from rfranzke March 18, 2024 05:09
@ialidzhikov
Copy link
Member

/assign

ialidzhikov
ialidzhikov reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a look with @dimitar-kostadinov and @Kostov6.
Minor cleanup suggestions, otherwise lgtm.

pkg/component/networking/vpn/seedserver/seedserver.go Show resolved Hide resolved
pkg/component/networking/vpn/seedserver/seedserver.go Show resolved Hide resolved
ialidzhikov
ialidzhikov approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 26, 2024

LGTM label has been added.

Git tree hash: 40405cbba84af59ece20e113ea2484b12e2c37f8

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@ary1992
Copy link
Contributor Author

ary1992 commented Mar 26, 2024

/retest

@gardener-prow gardener-prow bot merged commit 6e6e14e into gardener:master Mar 26, 2024
17 checks passed
@ary1992 ary1992 deleted the enh/drop-dh branch March 29, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@plkokanov plkokanov Awaiting requested review from plkokanov

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees

@ialidzhikov ialidzhikov

@rfranzke rfranzke

@ScheererJ ScheererJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cleanup] VPN Diffie–Hellman parameters no longer needed
4 participants
@ary1992 @rfranzke @ScheererJ @ialidzhikov