Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop graduated MachineControllerManagerDeployment feature gate #9450

Conversation

ScheererJ
Copy link
Contributor

@ScheererJ ScheererJ commented Mar 19, 2024

How to categorize this PR?

/area open-source
/kind cleanup

What this PR does / why we need it:
Drop graduated MachineControllerManagerDeployment feature gate.

Which issue(s) this PR fixes:
None.

Special notes for your reviewer:
Please note that was attempted already in the past (see #8691), but was reverted at the time with #8708. Meanwhile, the provider extensions for alicloud, aws, azure, gcp and openstack have adopted the corresponding gardener/gardener release since at least a month.

Release note:

Graduated `MachineControllerManagerDeployment` feature gate was removed.

/hold until release branch for v1.91 is created

@gardener-prow gardener-prow bot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Mar 19, 2024
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 19, 2024
@shafeeqes
Copy link
Contributor

/unhold

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@plkokanov
Copy link
Contributor

/assign

Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link
Contributor

gardener-prow bot commented Mar 25, 2024

LGTM label has been added.

Git tree hash: 26ec73ffc898560bcca0395746006dc8520ad826

@rfranzke
Copy link
Member

/approve

Copy link
Contributor

gardener-prow bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@gardener-prow gardener-prow bot merged commit 1c53b43 into gardener:master Mar 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants