New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore etcd
with 1 replica and scale it up after kapi
deployment for HA shoots
#9462
Conversation
/cherry-pick release v1.91 |
@shafeeqes: once the present PR merges, I will cherry-pick it on top of release v1.91 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
LGTM label has been added. Git tree hash: 6c6bd35f2e007d0d3311321e72497483b9b82c04
|
b5fce79
to
37b3a60
Compare
37b3a60
to
b688452
Compare
Thanks! |
/lgtm |
LGTM label has been added. Git tree hash: e18bf6a1ae3dab34c74d8d619cc0543f2c544a59
|
/hold |
/test pull-gardener-e2e-kind |
/unhold |
/test pull-gardener-e2e-kind-ha-single-zone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ishan16696, shafeeqes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-gardener-e2e-kind-ha-multi-zone |
@shafeeqes: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
How to categorize this PR?
/area control-plane-migration
/kind enhancement
What this PR does / why we need it:
With this PR during the
restore
phase of control plane migration of HA shoot clusters, the main and eventsetcd
s will be deployed with only 1 replica (with all other settings required for multi-node etcd) initially. After theetcd
s become ready, thekube-apiserver
is deployed and after thekube-apiserver
is ready we scale up the etcd replicas to 3.Previously the
kube-apiserver
was deployed only after:etcd
was created with 1 replica and restoredetcd
was scaled to 3 replicas and they became readyetcd
became readyThis would lead to a 3 minute increase in downtime for HA shoot clusters compared to non-HA shoot clusters during control plane migration.
After talking with @ishan16696 it turns out that we do not have to wait for all 3 replicas of the
etcd
s to be up and running before deploying the kube-apiserver. So with this approach the extra 3 minutes of downtime are no-longer present. Note that now we also only wait for 1 replica of the eventsetcd
to become ready before deploying the kube-apiserver, instead of waiting for all 3.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @ishan16696
/cc @shafeeqes if we could get this in the
v1.91.0
Release note: