Fix NodeNotHealthy alert with correct NodeNotReady taint #9470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
the
area/monitoring
gardener-prow
bot
added
kind/bug
adenitiu
changed the title
|
/retest |
|
LGTM label has been added. Git tree hash: 980b97a4b3b4717318f700ae16a419faf1a032be
|
timebertt
approved these changes
Mar 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind bug
What this PR does / why we need it:
This PR corrects the filtering query, as the current value v1beta1constants.LabelNodeCriticalComponent is wrong. The query was thought initially to handle
node.gardener.cloud/critical-components-not-ready, hence the correct value should be v1beta1constants.TaintNodeCriticalComponentsNotReadyWhich issue(s) this PR fixes:
False alerts of nodes being reported as not healthy.
Special notes for your reviewer:
Release note: