Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy a service for the Node Problem Detector component #9483

Merged

Conversation

istvanballok
Copy link
Contributor

How to categorize this PR?

/area monitoring
/kind enhancement

What this PR does / why we need it:

Deploy a service for the Node Problem Detector component to facilitate scraping the kube-system/node-problem-detector daemonset's endpoints by a Prometheus that is managed by shoot owners.

Which issue(s) this PR fixes:

Fixes #9481

Special notes for your reviewer:

cc @rickardsjp

Release note:

A service is added for the shoot cluster's kube-system/node-problem-detector daemonset

@gardener-prow gardener-prow bot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Mar 27, 2024
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2024
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link
Contributor

gardener-prow bot commented Mar 27, 2024

LGTM label has been added.

Git tree hash: 231935406065711327cda198c0972e7b7f9aec33

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@gardener-prow gardener-prow bot requested a review from rfranzke March 28, 2024 10:40
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
Copy link
Contributor

gardener-prow bot commented Mar 28, 2024

LGTM label has been added.

Git tree hash: 450c8d4645107566e39c3c2c63622ce65373bd94

@shafeeqes
Copy link
Contributor

/approve

Copy link
Contributor

gardener-prow bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shafeeqes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@shafeeqes
Copy link
Contributor

/test pull-gardener-e2e-kind-ha-single-zone-upgrade

@gardener-prow gardener-prow bot merged commit 7424d5d into gardener:master Apr 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Scraping of Node-Problem-Detector in kube-system-Namespace
4 participants