Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.91] Do not append reason to lastMaintenance.description if no feature gates or admission plugins are removed #9539

Merged
merged 4 commits into from Apr 5, 2024
Merged

[release-v1.91] Do not append reason to lastMaintenance.description if no feature gates or admission plugins are removed #9539

merged 4 commits into from Apr 5, 2024

Conversation

gardener-ci-robot
Copy link
Contributor

@gardener-ci-robot gardener-ci-robot commented Apr 5, 2024 •
edited

This is an automated cherry-pick of #9533

/assign shafeeqes

An issue causing the Shoot `status.lastMaintenance.description` to contain "Removed feature gates from" or  "Removed admission plugins from" messages with zero entries is now fixed.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Apr 5, 2024
Merged
@gardener-ci-robot gardener-ci-robot added kind/bug Bug area/quality Output qualification (tests, checks, scans, automation in general, etc.) related labels Apr 5, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2024
@oliver-goetz
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Apr 5, 2024

LGTM label has been added.

Git tree hash: ea6adfa0bd02f4fa11f09326d7b8622fe941cdf4

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@gardener-prow gardener-prow bot merged commit 6c416d0 into gardener:release-v1.91 Apr 5, 2024
16 checks passed
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-9533-to-release-v1.91 branch April 5, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees

@shafeeqes shafeeqes

@oliver-goetz oliver-goetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gardener-ci-robot @oliver-goetz @shafeeqes