Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul warning alerts #954

Merged
merged 1 commit into from Apr 29, 2019
Merged

Conversation

wyb1
Copy link
Contributor

@wyb1 wyb1 commented Apr 24, 2019

  • Alertmanagers will now send out warning alerts
  • Adjusted or removed warning alerts
  • Added tests for warning alerts
  • Added kube_pod_status_ready to Prometheus whitelist

Release note:

Alertmanagers now send out `warning` level alerts

rfranzke
rfranzke previously approved these changes Apr 24, 2019
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

- Alertmanagers will now send out warning alerts
- Adjusted or removed warning alerts
- Added tests for warning alerts
- Added `kube_pod_status_ready` to Prometheus whitelist
@wyb1
Copy link
Contributor Author

wyb1 commented Apr 26, 2019

changed the visibility of VPNProbeAPIServerProxyFailed to all.

Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 7026d9d into gardener:master Apr 29, 2019
@wyb1 wyb1 deleted the warning-alert-refactoring branch November 28, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants