Drop Infrastructure Cleanup Wait Period during shoot deletion
#9632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/usability
gardener-prow
bot
added
the
size/M
rfranzke
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Remove shoot.gardener.cloud/infrastructure-cleanup-wait-period-seconds from the example shoots in the repo
/cc @kon-angelo
|
Also, mention removal of |
…ds` annotation from shoot examples
|
/lgtm |
|
LGTM label has been added. Git tree hash: 4025f319f43f81ed52c578c9a602b2d73b713392
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kon-angelo, rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
Thanks, love it! |
dimitar-kostadinov
added a commit
to gardener/gardener-extension-registry-cache
that referenced
this pull request
May 10, 2024
…iod-seconds` annotation. Ref: gardener/gardener#9632.
gardener-prow bot
pushed a commit
to gardener/gardener-extension-registry-cache
that referenced
this pull request
May 10, 2024
* Bump github.com/gardener/gardener from 1.93.0 to 1.94.1 Bumps [github.com/gardener/gardener](https://github.com/gardener/gardener) from 1.93.0 to 1.94.1. - [Release notes](https://github.com/gardener/gardener/releases) - [Commits](gardener/gardener@v1.93.0...v1.94.1) --- updated-dependencies: - dependency-name: github.com/gardener/gardener dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Remove usage of `shoot.gardener.cloud/infrastructure-cleanup-wait-period-seconds` annotation. Ref: gardener/gardener#9632. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dimitar Kostadinov <dimitar.kostadinov@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind cleanup
What this PR does / why we need it:
There is a
Infrastructure Cleanup Wait Periodof 5 minutes from the times where service finalizers have not been enabled by default yet. This changed a long time ago. Thus, this PR removes the cleanup period.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: