Only update network policy allow-to-runtime-apiserver after resolver has been synced
#9644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olivir Goetz <o.goetz@sap.com>
gardener-prow
bot
added
area/control-plane
gardener-prow
bot
added
the
size/S
rfranzke
reviewed
Apr 23, 2024
Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
|
LGTM label has been added. Git tree hash: d95248eefe9e0960502cd5bec10bfb85a5452334
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
The lookup of the IP address of the kube-apiserver via DNS from its external domain name can take some several seconds in rare situations due to network issues. In these cases, the network policy
allow-to-runtime-apiservermust not be updated until the resolver has resolved the domain name successfully. Especially on startup of the gardenlet, the first reconciliation of the network policy can occur too early.A check is added to skip the update of the network policy in such situations.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: