Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce minAllowed values from kube-apiserver and kube-controller-manager #9654

Merged
merged 2 commits into from Apr 25, 2024

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Apr 24, 2024

How to categorize this PR?

/area monitoring
/kind enhancement

What this PR does / why we need it:
This PR reduces minAllowed (H)VPA minAllowed values from kube-apiserver and kube-controller-manager as suggested in #9562.

Which issue(s) this PR fixes:
Part of #9562

Special notes for your reviewer:
N/A

Release note:

The kube-controller-manager's (H)VPA minAllowed memory is reduced from `100Mi` to `50Mi`. The kube-apiserver's HVPA minAllowed memory is reduced from `400M` to `200M`. 

@gardener-prow gardener-prow bot added the area/monitoring Monitoring (including availability monitoring and alerting) related label Apr 24, 2024
@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Apr 24, 2024
@gardener-prow gardener-prow bot requested a review from shafeeqes April 24, 2024 09:11
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2024
@ialidzhikov ialidzhikov changed the title Reduce minAllowed (H)VPA minAllowed values from kube-apiserver and kube-controller-manager Reduce minAllowed values from kube-apiserver and kube-controller-manager Apr 24, 2024
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link
Contributor

gardener-prow bot commented Apr 25, 2024

LGTM label has been added.

Git tree hash: 3bf8f6bdadad3e0fdb3f62bdc22451d0384ede19

Copy link
Contributor

gardener-prow bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
Copy link
Contributor

gardener-prow bot commented Apr 25, 2024

@ialidzhikov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-e2e-kind-ha-multi-zone 9982b3d link unknown /test pull-gardener-e2e-kind-ha-multi-zone

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gardener-prow gardener-prow bot merged commit 5d7d9a0 into gardener:master Apr 25, 2024
17 checks passed
@ialidzhikov ialidzhikov deleted the enh/reduce-min-allowed branch April 26, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants