Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet config has podPidsLimit instead of podPIDsLimit #971

Merged
merged 1 commit into from May 2, 2019
Merged

kubelet config has podPidsLimit instead of podPIDsLimit #971

merged 1 commit into from May 2, 2019

Conversation

rfranzke
Copy link
Member

What this PR does / why we need it:
The kubelet config does not contain podPIDsLimit but podPidsLimit (see https://github.com/kubernetes/kubelet/blob/release-1.14/config/v1beta1/types.go#L465)

Release note:

The kubelet config contained an invalid option that prevented the pod pid limit feature to work properly - this has been fixed now.

@rfranzke rfranzke requested a review from a team as a code owner April 30, 2019 14:54
@timuthy timuthy merged commit 9be2846 into gardener:master May 2, 2019
@rfranzke rfranzke deleted the fix/pod-pids-limit branch June 4, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvladev mvladev mvladev approved these changes

Assignees
No one assigned
Labels
kind/bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rfranzke @mvladev @gardener-robot-ci-1 @timuthy