Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imagevector Merge + types #974

Merged
merged 1 commit into from May 2, 2019
Merged

Fix imagevector Merge + types #974

merged 1 commit into from May 2, 2019

Conversation

adracus
Copy link
Contributor

@adracus adracus commented Apr 30, 2019 •
edited by rfranzke

What this PR does / why we need it:
Fixes an issue with the merge behavior of an ImageVector not behaving as expected.
Implement a 'best match' algorithm, refine the types of ImageVector and add tons of tests.

Special notes for your reviewer:
cc @jia-jerry

Release note:

An issue with the merge behaviour of the image vector has been fixed when images are overwritten.

@adracus adracus added reviewed/ok-to-test topology/garden Affects Garden clusters size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. platform/all kind/cleanup Something that is not needed anymore and can be cleaned up labels Apr 30, 2019
@adracus adracus requested a review from a team as a code owner April 30, 2019 15:47
rfranzke
rfranzke approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit e6504d4 into gardener:master May 2, 2019
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia-jerry jia-jerry jia-jerry left review comments

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up platform/all size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. topology/garden Affects Garden clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adracus @rfranzke @jia-jerry @gardener-robot-ci-1 @gardener-robot