[GEP-19] Adapt monitoring configuration for shoot control plane components #9848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/monitoring
46 tasks
gardener-prow
bot
added
the
size/XXL
rfranzke
force-pushed
the
gep19/in-tree-controlplane
branch
from
60a2e17
to
47e726f
Compare
|
/assign |
ScheererJ
reviewed
May 27, 2024
pkg/component/autoscaling/clusterautoscaler/cluster_autoscaler.go
Outdated
Show resolved
Hide resolved
pkg/component/nodemanagement/machinecontrollermanager/machine_controller_manager.go
Show resolved
Hide resolved
This seperation is not clear/does not bring benefits since the `SystemComponents` struct also contains monitoring-related deployers. To correct these, we would have to introduce a struct like `MonitoringSystemComponents` or whatever, but I don't think that's reasonable. Using the `ControlPlane` and `SystemComponents` alone seems good enough and is also clear because it directly shows where the respective component is deployed.
Similar to previous commit
The `__meta_kubernetes_{pod_node_name,namespace}` relabel configs
are automatically added by `prometheus-operator`, so no need to specify
them explicitly.
rfranzke
force-pushed
the
gep19/in-tree-controlplane
branch
from
47e726f
to
3af7510
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: d281b39ab1e43174ea9b4bbd7ede0cb77b5b6fd1
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind enhancement
What this PR does / why we need it:
As a follow-up of #9695 and similar to #9737, this PR adapts the monitoring configuration for the shoot control plane components running inside the seed cluster.
Which issue(s) this PR fixes:
Part of #9065
Special notes for your reviewer:
/cc @ScheererJ
Release note: