Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Shoot cleanup for extended API groups #989

Merged
merged 1 commit into from May 7, 2019
Merged

Fix Shoot cleanup for extended API groups #989

merged 1 commit into from May 7, 2019

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented May 7, 2019

What this PR does / why we need it:
This PR adds another step to the Shoot deletion flow which removes CustomResources and APIServices before further resources get deleted. It enables those resources to be cleaned up by responsible controllers first.

Special notes for your reviewer:
SequentialSliced did not work as expected in the deletion workflow which is why this PR includes a fix for it as well.

Release note:

Gardener removes `CustomResources` and `APIServices` during the deletion of a Shoot cluster before further resources get deleted.

@timuthy @adracus
Fix Shoot cleanup for extended API groups
c9c8f8f 
Co-authored-by: Axel Christ <axel.christ@sap.com>
@timuthy timuthy added kind/bug Bug platform/all topology/shoot Affects Shoot clusters area/robustness Robustness, reliability, resilience related component/gardener Gardener priority/normal size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2019
@timuthy timuthy requested a review from a team as a code owner May 7, 2019 08:55
rfranzke
rfranzke approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit c900669 into gardener:master May 7, 2019
@timuthy timuthy deleted the fix/shoot-cleanup branch June 4, 2019 11:25
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related component/gardener Gardener kind/bug Bug platform/all size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topology/shoot Affects Shoot clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timuthy @rfranzke @gardener-robot-ci-1 @gardener-robot