Added dependency-watchdog #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amshuman-kr
suggested changes
May 7, 2019
charts/seed-controlplane/charts/dependency-watchdog/templates/configmap.yaml
Outdated
Show resolved
Hide resolved
pkg/controllermanager/controller/shoot/shoot_control_reconcile.go
Outdated
Show resolved
Hide resolved
georgekuruvillak
force-pushed
the
add-dependency-watchdog
branch
2 times, most recently
from
b01ff77
to
efec6b5
Compare
rfranzke
requested changes
May 8, 2019
charts/seed-controlplane/charts/dependency-watchdog/templates/rbac.yaml
Outdated
Show resolved
Hide resolved
pkg/controllermanager/controller/shoot/shoot_control_reconcile.go
Outdated
Show resolved
Hide resolved
georgekuruvillak
force-pushed
the
add-dependency-watchdog
branch
2 times, most recently
from
6fa0441
to
b0b650f
Compare
timuthy
requested changes
May 10, 2019
charts/seed-controlplane/charts/dependency-watchdog/templates/deployment.yaml
Show resolved
Hide resolved
charts/seed-controlplane/charts/dependency-watchdog/templates/deployment.yaml
Show resolved
Hide resolved
georgekuruvillak
force-pushed
the
add-dependency-watchdog
branch
from
b0b650f
to
05208cc
Compare
|
Tests need to be fixed, after that it can be merged. |
georgekuruvillak
force-pushed
the
add-dependency-watchdog
branch
from
05208cc
to
a88250f
Compare
georgekuruvillak
force-pushed
the
add-dependency-watchdog
branch
from
a88250f
to
92a1772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: When etcd-main becomes ready after a prolonged period of time, the control-plane components had gone into CrashloopBackoff`. The control-plane pods may have to wait till 300 seconds before restarting containers. This fix aims to reduce the downtime caused due to pod waiting for MaxContainerBackOff to have the container recreated by restarting the control-plane pods in CrashloopBackoff when the etcd-main service gets serviceable endpoints.
Which issue(s) this PR fixes:
Fixes #148
Special notes for your reviewer:
Release note: