Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Alicloud EIP type PayByTraffic #994

Merged
merged 1 commit into from May 14, 2019
Merged

Change Alicloud EIP type PayByTraffic #994

merged 1 commit into from May 14, 2019

Conversation

jia-jerry
Copy link
Contributor

@jia-jerry jia-jerry commented May 8, 2019

What this PR does / why we need it:
Change Alicloud EIP type PayByTraffic. It will save a lot of money. Origin setup was charged more than 1/2 of VM instances!!!

Gardener does now create Alicloud EIPs with `PayByTraffic` policy for new clusters to save costs.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed via Slack: It won't work that way. You can only do that for new shoots. Check in the Alicloud Botanist whether the Terraform config already exists (if yes, then preserve old logic (PayByBandWidth). Otherwise, go ahead with PayByTraffic.

@rfranzke
Copy link
Member

rfranzke commented May 8, 2019

/cc @adracus

This should be taken over into the Alicloud extension infrastructure controller ⚠️

@jia-jerry
Copy link
Contributor Author

As discussed via Slack: It won't work that way. You can only do that for new shoots. Check in the Alicloud Botanist whether the Terraform config already exists (if yes, then preserve old logic (PayByBandWidth). Otherwise, go ahead with PayByTraffic.

Hi @rfranzke , Now we will keep old pay type for exsiting shoot. The new shoot will use PayByTraffic.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants