Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix-v0.1] Fix darwin-arm64 release asset upload #18

Merged
merged 1 commit into from Nov 26, 2021

Conversation

petersutter
Copy link
Contributor

What this PR does / why we need it:
With this PR the gardenlogin darwin-arm64 release asset will be uploaded on the next release

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed missing `gardenlogin_darwin_arm64` release asset upload

(cherry picked from commit f308080)
@petersutter petersutter requested a review from a team as a code owner November 25, 2021 17:43
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Nov 25, 2021
@gardener-robot
Copy link

@petersutter You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the needs/review Needs review label Nov 25, 2021
@petersutter petersutter changed the base branch from master to hotfix-v0.1 November 25, 2021 17:43
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Nov 25, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 25, 2021
@petersutter petersutter changed the title [hotfix-v0.1] Fix darwin-arm64 release asset [hotfix-v0.1] Fix darwin-arm64 release asset upload Nov 26, 2021
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review labels Nov 26, 2021
@petersutter petersutter merged commit a0f418e into hotfix-v0.1 Nov 26, 2021
@petersutter petersutter deleted the bug/hotfix-darwin-amd64-release-asset branch November 26, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants