Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override current-context of garden cluster kubeconfig #24

Merged
merged 2 commits into from Dec 15, 2021

Conversation

petersutter
Copy link
Contributor

What this PR does / why we need it:
This PR allows to override the current context of the garden cluster kubeconfig.

Example:

gardens:
- identity: landscape-dev # Unique identity of the garden cluster. See cluster-identity ConfigMap in kube-system namespace of the garden cluster
  kubeconfig: ~/path/to/garden-cluster/kubeconfig.yaml
  context: different-context # Overrides the current-context of the garden cluster kubeconfig  

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

You can now override the current context of the `garden` cluster `kubeconfig` by setting the `gardens[].context` property in your `gardenlogin` config file.

@petersutter petersutter requested a review from a team as a code owner December 14, 2021 12:16
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 14, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 14, 2021
@petersutter petersutter changed the title Allow to set current context of kubeconfig Override current context of kubeconfig Dec 14, 2021
@petersutter petersutter changed the title Override current context of kubeconfig Override current context of garden cluster kubeconfig Dec 14, 2021
@petersutter petersutter changed the title Override current context of garden cluster kubeconfig Override current-context of garden cluster kubeconfig Dec 14, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 14, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 14, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 15, 2021
Copy link

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 15, 2021
@grolu grolu self-requested a review December 15, 2021 10:40
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 15, 2021
@petersutter petersutter merged commit 7afb062 into master Dec 15, 2021
@petersutter petersutter deleted the enh/context branch December 15, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants