Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support v1 ExecCredential #43

Merged
merged 6 commits into from Mar 21, 2023
Merged

Support v1 ExecCredential #43

merged 6 commits into from Mar 21, 2023

Conversation

petersutter
Copy link
Contributor

What this PR does / why we need it:
Fixed issue when exec plugin in kubeconfig is configured to use API version client.authentication.k8s.io/v1:

users:
- name: garden-core--peter-test
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1

Previously the error Error: failed to complete command options: cannot convert to ExecCredential: %!w(<nil>) was returned.

With this PR client.authentication.k8s.io/v1 is supported. Depending on the configured API version an ExecCredential with the same API version is returned. Currently supported versions:

  • client.authentication.k8s.io/v1
  • client.authentication.k8s.io/v1beta1

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`client.authentication.k8s.io/v1` is now supported

@petersutter petersutter requested a review from a team as a code owner March 13, 2023 18:06
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 13, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 13, 2023
@petersutter petersutter mentioned this pull request Mar 14, 2023
Merged
holgerkoser
holgerkoser approved these changes Mar 20, 2023
View reviewed changes
Copy link

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 20, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2023
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Mar 21, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2023
grolu
grolu approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Mar 21, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2023
@petersutter petersutter merged commit e950a42 into master Mar 21, 2023
@petersutter petersutter deleted the enh/clientauth-versions branch March 21, 2023 19:29
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 21, 2023
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@petersutter @holgerkoser @grolu @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot