-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support autoscaling/v2 API alongside autoscaling/v2beta1 #121
Support autoscaling/v2 API alongside autoscaling/v2beta1 #121
Conversation
/invite @andrerun |
8bc2159
to
59f7623
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Check the question about the v2 code syncing multiple fields where the v2beta1 code is only syncing MinReplicas. Also whether you actually want to update cache before validating the incoming object instance.
The rest are all cosmetic nits - just check if you want to make changes based on any of them.
84ce76e
to
9d5da89
Compare
75f7725
to
b105ef2
Compare
b105ef2
to
ff81f2f
Compare
What this PR does / why we need it:
Adds conversions to use
autoscaling/v2beta1
in all calls to kube-apiserver whenautoscaling/v2
is not available. Internally, the HVPA continues to operate onautoscaling/v2beta1
objects.This is essentially what g/g does as well: we're using
autoscaling/v2
for all k8s versions >=1.23, which introducedautoscaling/v2
.Which issue(s) this PR fixes:
fixes #104
Special notes for your reviewer:
Release note: