Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick Cap requests to existing limits, if ControlledValues: RequestsOnly is set (#98) #99

Merged
merged 1 commit into from
Jun 15, 2022
Merged

cherry-pick Cap requests to existing limits, if ControlledValues: RequestsOnly is set (#98) #99

merged 1 commit into from
Jun 15, 2022

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Jun 15, 2022

What this PR does / why we need it:
cherry-pick of #98

Release note:

Fix an issue where the HVPA would set Requests higher than Limits if `ControlledValues: RequestsOnly` is set

@voelzmo
Cap requests to existing limits, if ControlledValues: RequestsOnly is…
12d3a8d 
… set (gardener#98)

* Cap Requests to Limits if necessary

* Add test for Resources > Limits
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jun 15, 2022
@voelzmo voelzmo marked this pull request as ready for review June 15, 2022 11:29
@voelzmo voelzmo requested a review from a team as a code owner June 15, 2022 11:29
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 15, 2022
@shreyas-s-rao
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 15, 2022
@shreyas-s-rao shreyas-s-rao merged commit 3a02d3c into gardener:rel-v0.5 Jun 15, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@voelzmo @shreyas-s-rao @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot