Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testsetup by using the new testenv tool #209

Merged
merged 1 commit into from
May 31, 2021

Conversation

schrodit
Copy link

How to categorize this PR?

/area dev-productivity
/priority 3

What this PR does / why we need it:

Replaces the curl based testenv setup with the new controller-runtime testenv tool.
This new tool should make it easier in the future to update to newer k8s versions or even test different versions.

Which issue(s) this PR fixes:
Fixes #208

Special notes for your reviewer:

Release note:

NONE

@schrodit schrodit requested a review from a team as a code owner May 28, 2021 11:42
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) priority/3 Priority (lower number equals higher priority) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 28, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2021
hack/setup-testenv.sh Show resolved Hide resolved
test/utils/envtest/environment.go Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label May 31, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 31, 2021
@schrodit schrodit requested a review from achimweigel May 31, 2021 07:37
@schrodit schrodit merged commit a34fdb6 into gardener:master May 31, 2021
@schrodit schrodit deleted the improve-setup branch May 31, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new EnvTest Binaries Setup Tool
5 participants