Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix flake enablement for landscapercli #214

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

vasu1124
Copy link
Member

@vasu1124 vasu1124 commented Jan 16, 2024

What this PR does / why we need it:

We want to enable landscapercli for the nix community.

# with Nix (macOS, Linux, and Windows)
nix run github:gardener/landscapercli -- version

# development version
nix profile install github:gardener/landscapercli

landscaper-cli --help

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 16, 2024
@gardener-robot-ci-3
Copy link
Contributor

Thank you @vasu1124 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@guewa guewa added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 17, 2024
guewa
guewa previously approved these changes Jan 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024
@guewa guewa dismissed their stale review January 17, 2024 10:35

needs rebasing

@In-Ko
Copy link
Collaborator

In-Ko commented Jan 17, 2024

Thanks @vasu1124 for your contribution. Before we merge this (and therefore have to support this in the future), I'd like to know ifsomeone concretely asked for this ? Or do you have other reasons for this PR ?

@vasu1124
Copy link
Member Author

Thanks @vasu1124 for your contribution. Before we merge this (and therefore have to support this in the future), I'd like to know ifsomeone concretely asked for this ? Or do you have other reasons for this PR ?

We indeed have teams that enable their dev environments with nix, which transports a number of advantages. I think the overhead is not too much. This nix flake btw. also automates the binary for aarch64. The other option that you could also consider is homebrew. => make it simple for users to consume and stay uptodate with landscaper-cli.

@gardener-robot
Copy link
Contributor

@enrico-kaack-comp, @achimweigel, @robertgraeff, @In-Ko You have pull request review open invite, please check

@achimweigel achimweigel merged commit 73c4144 into gardener:master Jan 19, 2024
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants