Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Multi-Arch Images #156

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Build Multi-Arch Images #156

merged 1 commit into from
Oct 11, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Sep 30, 2022 •
edited

How to categorize this PR?

/kind enhancement
/area logging

What this PR does / why we need it:
This PR lets the CI pipeline build multi-arch images with support for linux/amd64 and linux/arm64.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Now that CI/CD uses arm nodes for building arm images we can go ahead with this change.

Release note:

Published docker images for Logging are now multi-arch ready. They support `linux/amd64` and `linux/arm64`.

@gardener-robot
Copy link

@acumino Labels kind/todo, priority/normal do not exist.

@gardener-robot gardener-robot added area/logging Logging related needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 30, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 30, 2022
@gardener-robot gardener-robot added the kind/enhancement Enhancement, improvement, extension label Sep 30, 2022
@gardener-robot
Copy link

@acumino Label priority/normal does not exist.

@gardener-robot
Copy link

@nickytd, @Kristian-ZH, @vlvasilev You have pull request review open invite, please check

Kristian-ZH
Kristian-ZH approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 3, 2022
@Kristian-ZH
Copy link
Contributor

Thanks for the PR!

@vlvasilev vlvasilev merged commit d373a71 into gardener:master Oct 11, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kristian-ZH Kristian-ZH Kristian-ZH approved these changes

@vlvasilev vlvasilev Awaiting requested review from vlvasilev

@nickytd nickytd Awaiting requested review from nickytd nickytd is a code owner

Assignees
No one assigned
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acumino @gardener-robot @Kristian-ZH @gardener-robot-ci-1 @vlvasilev