Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy gardener informers #188

Merged
merged 4 commits into from May 18, 2023
Merged

Copy gardener informers #188

merged 4 commits into from May 18, 2023

Conversation

vlvasilev
Copy link
Collaborator

How to categorize this PR?

/kind enhancement
/area logging

What this PR does / why we need it:
With this PR the Cluster informer which does not exist anymore after Gardener v1.5.0 is copied directly into the repo.
Thus the gardener is updated to the latest version and the client-go module is updated from v.017.0 to v0.26.2 which may or may not resolve the issue with the memory leak in the fluent-bit-to-loki plugin related to the Cluster informer.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Update `k8s.io/client-go` from v0.17.0 to v0.26.2

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 1, 2023
@gardener-robot gardener-robot added area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 1, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 1, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 1, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 1, 2023
@gardener-robot
Copy link

@Kristian-ZH, @nickytd You have pull request review open invite, please check

@nickytd
Copy link
Collaborator

nickytd commented May 9, 2023

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels May 9, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 9, 2023
@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label May 18, 2023
@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels May 18, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 18, 2023
@vlvasilev vlvasilev merged commit 7c15fcb into gardener:master May 18, 2023
14 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kristian-ZH Kristian-ZH Awaiting requested review from Kristian-ZH

@nickytd nickytd Awaiting requested review from nickytd nickytd is a code owner

Assignees
No one assigned
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vlvasilev @gardener-robot @nickytd @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3