-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Timeout max Backoff and minBackoff wait #60
Merged
Kristian-ZH
merged 1 commit into
gardener:master
from
vlvasilev:set-timeout-retries-and-loglevel
Aug 14, 2020
Merged
Add Timeout max Backoff and minBackoff wait #60
Kristian-ZH
merged 1 commit into
gardener:master
from
vlvasilev:set-timeout-retries-and-loglevel
Aug 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 14, 2020
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 14, 2020
vlvasilev
force-pushed
the
set-timeout-retries-and-loglevel
branch
from
August 14, 2020 07:37
7334aee
to
467f8df
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 14, 2020
/assign @vpnachev |
Why you push binaries ( |
vlvasilev
force-pushed
the
set-timeout-retries-and-loglevel
branch
from
August 14, 2020 08:45
467f8df
to
3c2fc5c
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 14, 2020
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 14, 2020
vlvasilev
force-pushed
the
set-timeout-retries-and-loglevel
branch
from
August 14, 2020 08:56
3c2fc5c
to
e6b126e
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 14, 2020
vlvasilev
force-pushed
the
set-timeout-retries-and-loglevel
branch
from
August 14, 2020 08:57
e6b126e
to
0cac46c
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 14, 2020
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 14, 2020
vlvasilev
force-pushed
the
set-timeout-retries-and-loglevel
branch
from
August 14, 2020 09:03
0cac46c
to
3225024
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 14, 2020
vlvasilev
force-pushed
the
set-timeout-retries-and-loglevel
branch
from
August 14, 2020 09:27
3225024
to
281dbeb
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 14, 2020
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 14, 2020
can you please, also add timestamps in the logs |
vpnachev
reviewed
Aug 14, 2020
vlvasilev
force-pushed
the
set-timeout-retries-and-loglevel
branch
from
August 14, 2020 12:26
281dbeb
to
f753bb2
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 14, 2020
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 14, 2020
Kristian-ZH
suggested changes
Aug 14, 2020
Kristian-ZH
suggested changes
Aug 14, 2020
vlvasilev
force-pushed
the
set-timeout-retries-and-loglevel
branch
from
August 14, 2020 13:36
f753bb2
to
0131b5d
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 14, 2020
vpnachev
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Kristian-ZH
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this PR we add in fluent-bit-to-loki plugin Timeout setting.
The Timeout defines how much time the plugin will wait for response from the loki before consider the sending as fail.
Also we add MinBackoff and MaxBackoff.
MinBackoff is the first wait after failed sending.
MaxBackoff is the longest allowed wait after failed sending.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: