Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timeout max Backoff and minBackoff wait #60

Merged

Conversation

vlvasilev
Copy link
Collaborator

@vlvasilev vlvasilev commented Aug 14, 2020

What this PR does / why we need it:
With this PR we add in fluent-bit-to-loki plugin Timeout setting.
The Timeout defines how much time the plugin will wait for response from the loki before consider the sending as fail.
Also we add MinBackoff and MaxBackoff.
MinBackoff is the first wait after failed sending.
MaxBackoff is the longest allowed wait after failed sending.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add Timeout, MaxBackoff and MinBackoff wait settings to the fluent-bit-to-loki output plugin.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 14, 2020
@vlvasilev vlvasilev force-pushed the set-timeout-retries-and-loglevel branch from 7334aee to 467f8df Compare August 14, 2020 07:37
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 14, 2020
@vlvasilev
Copy link
Collaborator Author

/assign @vpnachev

@ialidzhikov
Copy link
Member

Why you push binaries (fluent-bit-to-loki/build/out_loki.so)?

@vlvasilev vlvasilev force-pushed the set-timeout-retries-and-loglevel branch from 467f8df to 3c2fc5c Compare August 14, 2020 08:45
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020
@vlvasilev vlvasilev force-pushed the set-timeout-retries-and-loglevel branch from 3c2fc5c to e6b126e Compare August 14, 2020 08:56
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 14, 2020
@vlvasilev vlvasilev force-pushed the set-timeout-retries-and-loglevel branch from e6b126e to 0cac46c Compare August 14, 2020 08:57
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020
@vlvasilev vlvasilev force-pushed the set-timeout-retries-and-loglevel branch from 0cac46c to 3225024 Compare August 14, 2020 09:03
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 14, 2020
@vlvasilev vlvasilev force-pushed the set-timeout-retries-and-loglevel branch from 3225024 to 281dbeb Compare August 14, 2020 09:27
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020
@Kristian-ZH
Copy link
Contributor

can you please, also add timestamps in the logs

fluent-bit-to-loki/pkg/lokiplugin/loki.go Outdated Show resolved Hide resolved
fluent-bit-to-loki/pkg/lokiplugin/loki.go Outdated Show resolved Hide resolved
@vlvasilev vlvasilev force-pushed the set-timeout-retries-and-loglevel branch from 281dbeb to f753bb2 Compare August 14, 2020 12:26
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2020
@vlvasilev vlvasilev force-pushed the set-timeout-retries-and-loglevel branch from f753bb2 to 0131b5d Compare August 14, 2020 13:36
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 14, 2020
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Aug 14, 2020
Copy link
Contributor

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Kristian-ZH Kristian-ZH merged commit bd263a1 into gardener:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants