-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Gardener credentials data keys #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
area/usability
Usability related
kind/enhancement
Enhancement, improvement, extension
platform/alicloud
Alicloud platform/infrastructure
priority/normal
needs/review
Needs review
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
labels
Nov 29, 2020
minchaow
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
labels
Nov 30, 2020
/hold until gardener/machine-controller-manager#578 is merged. |
gardener-robot
added
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Nov 30, 2020
/assign @hardikdr @prashanth26 @amshuman-kr @AxiomSamarth |
gardener-robot
removed
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Dec 2, 2020
prashanth26
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
AxiomSamarth
approved these changes
Dec 2, 2020
gardener-robot
added
priority/3
Priority (lower number equals higher priority)
and removed
priority/3
Priority (lower number equals higher priority)
labels
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
area/usability
Usability related
kind/enhancement
Enhancement, improvement, extension
platform/alicloud
Alicloud platform/infrastructure
reviewed/lgtm
Has approval for merging
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/area open-source usability
/kind enhancement
/priority normal
/platform alicloud
What this PR does / why we need it:
All the secret keys used by Gardener are now also allowed as alternatives for this machine-controller-manager plugin. This helps to not make mappings for the data keys.
Special notes for your reviewer:
ℹ️ Similar improvement for in-tree driver: gardener/machine-controller-manager@0e41070 (gardener/machine-controller-manager#578)
Release note: