Add integration tests #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mkmittal Thank you for your contribution. |
|
@Mkmittal You need rebase this pull request with latest master branch. Please check. |
gardener-robot
added
needs/rebase
|
Thank you @Mkmittal for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | PGP Private Key | e8e8eba | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Mkmittal
force-pushed
the
Add-Integration-tests
branch
from
e5ba541
to
2618c77
Compare
gardener-robot
added
size/l
himanshu-kun
requested changes
Jun 19, 2022
himanshu-kun
requested changes
Jun 20, 2022
himanshu-kun
requested changes
Jun 22, 2022
himanshu-kun
added
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
size/xl
himanshu-kun
added
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
himanshu-kun
added
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
|
/lgtm |
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds integration test
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Had to change a Prometheus dependency in the go mod.
Release note: