Do not set cascade delete for resources not part of VM creation #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
the
size/m
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
rishabh-11
added
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
|
Thanks for fix. We should add an Integration Test backlog to cover this case later. |
rishabh-11
added
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
aaronfern
approved these changes
Apr 13, 2024
unmarshall
requested changes
Apr 13, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
rishabh-11
added
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot
added
the
status/closed
rishabh-11
added a commit
to rishabh-11/machine-controller-manager-provider-azure
that referenced
this pull request
Apr 13, 2024
…ener#142) * do not set cascade delete for resources not part of VM creation * fix errors * address review comments
Merged
rishabh-11
added a commit
that referenced
this pull request
Apr 13, 2024
#143) * do not set cascade delete for resources not part of VM creation * fix errors * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a bug in the DeleteMachine function where cascade delete option was set for all resources attached to the VM. It should be set only for the resources that were created as a part of VM creation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: